-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where Query parser ignored 0 strings #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
approved these changes
Sep 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left one small comment. 👍
src/Database/Query.php
Outdated
@@ -251,7 +251,9 @@ public static function parse(string $filter): self | |||
} else { | |||
// Append from parap builder. Either value, or array | |||
if (empty($currentArrayParam)) { | |||
if (!empty($currentParam)) { | |||
// if (!empty($currentParam)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover
stnguyen90
force-pushed
the
fix-zero-value-in-array-query
branch
from
September 26, 2022 19:27
7b8d5ff
to
c75fc11
Compare
stnguyen90
changed the title
Fix bugs where Query parser ignored 0 strings
Fix bug where Query parser ignored 0 strings
Sep 27, 2022
stnguyen90
force-pushed
the
fix-zero-value-in-array-query
branch
from
September 30, 2022 15:00
c75fc11
to
4e34926
Compare
stnguyen90
force-pushed
the
fix-zero-value-in-array-query
branch
from
September 30, 2022 15:01
4e34926
to
6d1c1d4
Compare
christyjacob4
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Query::parse()
parsed a string likeequal("attr", [0])
it ignored the 0 string so the values was an empty array. This caused a 500 error in Appwrite.Related issue: