-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backend and rework rendering pipeline #4846
Conversation
Fix the `qxl_state->gl_draw_cookie == GL_DRAW_COOKIE_INVALID` assertion error caused by a race condition.
Validation testing by running SuperTuxKart for 2 hours without crashing:
|
Is there OpenGL 3.2 or whatever is needed by SuperTuxKart available? Or is it just running with broken rendering? |
It’s definitely not fully rendering (like I don’t think shadow maps are working). But I’m more interested in not crashing the VM then all 3D graphics are working. |
iPad ran overnight without crashing or going out of memory :) |
@osy & @ktprograms, I was able to get SuperTuxKart also working on my M1 iPad Pro. However, I'd still be concerned there might be a memory leak with the metal backend. I tried to run glxgears using the same setup, and it would run for a second or two and then UTM would crash. While glxgears did run, it ran very smoothly. Perhaps glxgears is using some OpenGL calls that SuperTuxKart is not. Yet, if UTM crashes with GL-acceleration on glxgears, I'd be concerned that it might crash on some other basic GL-accelerated programs not yet tested. Can anyone else confirm whether they can run glxgears on UTM without it crashing? I apologize but for some reason my UTM won't produce a debug file after the crash for me to export for review. The system I tested it on was: (Of note, I also tested glxgears on two other debian-based distributions x86-64 distros [Sparkylinux & antiX], and they similarly crashed with glxgears) glxgears is available in Debian 11 by the mesa-utils pkg in the Debian repository Fyi |
GL_DRAW_COOKIE_INVALID
errorCSRenderer
to sync up better with GL texture from the QEMU process. This will make graphics feel more smooth.Fixes #3053
Fixes #3060
Fixes #3519
Fixes #4449
Fixes #4722