vm: allow creation with illegal path characters in name

Fixes #4385
utmapp · Sep 10, 2022 · 64ba7f8 · 64ba7f8
1 parent 39b8c17
commit 64ba7f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Managers/UTMVirtualMachine.m b/Managers/UTMVirtualMachine.m
@@ -133,6 +133,8 @@ + (NSString *)virtualMachineName:(NSURL *)url {
 }
 
 + (NSURL *)virtualMachinePath:(NSString *)name inParentURL:(NSURL *)parent {
+    NSCharacterSet *illegalFileNameCharacters = [NSCharacterSet characterSetWithCharactersInString:@"/:\\?%*|\"<>"];
+    name = [[name componentsSeparatedByCharactersInSet:illegalFileNameCharacters] componentsJoinedByString:@"-"];
     return [[parent URLByAppendingPathComponent:name] URLByAppendingPathExtension:kUTMBundleExtension];
 }
 

diff --git a/Managers/UTMVirtualMachine.swift b/Managers/UTMVirtualMachine.swift
@@ -73,7 +73,7 @@ extension UTMVirtualMachine: ObservableObject {
     func saveUTM() async throws {
         let fileManager = FileManager.default
         let existingPath = path
-        let newPath = existingPath.deletingLastPathComponent().appendingPathComponent(config.name).appendingPathExtension("utm")
+        let newPath = UTMVirtualMachine.virtualMachinePath(config.name, inParentURL: existingPath.deletingLastPathComponent())
         do {
             try await config.save(to: existingPath)
             try await updateRegistryFromConfig()