Skip to content

Sync line-height and ROW_HEIGHT using a single source to avoid mismatch #10

@utkuakyuz

Description

@utkuakyuz

medium

The line-height is hardcoded to 20px. This value is tightly coupled with the ROW_HEIGHT constant (also 20) in VirtualizedDiffViewer.tsx. If one value changes, the other must be updated as well to ensure correct height calculations. This can be error-prone.

Consider using CSS Custom Properties (variables) to define this value in one place and use it in both CSS and JavaScript. This would make the relationship explicit and easier to maintain.

Originally posted by @gemini-code-assist[bot] in #9 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions