Skip to content

GH-800: Self Review #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
utkarshg6 wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

GH-800: Self Review #21

utkarshg6 wants to merge 54 commits into from

Conversation

@utkarshg6
Copy link
Owner

@utkarshg6 utkarshg6 commented Sep 11, 2024

No description provided.

utkarshg6 added 30 commits June 13, 2024 17:45
@utkarshg6
GH-800: Write the most basic TODOs for this card
4cfa253
@utkarshg6
GH-800: Add todos for renaming purposes
07cfef9
@utkarshg6
GH-800: Add a message scheduler for purging the stream key
62db40f
@utkarshg6
GH-800: Improve the test handle_client_response_payload_purges_stream…
e4199ae 
…_keys_for_terminal_response
@utkarshg6
GH-800: Make delay configurable via constant
ee8f897
@utkarshg6
GH-800: introduce StreamSenders
91323d4
@utkarshg6
GH-800: introduce channel for shutdown signal
7cc2fbb
@utkarshg6
GH-800: add test connection_shutdown_test.rs
d784157
@utkarshg6
GH-800: test drive the shutdown signal in StreamReader
14a5de3
@utkarshg6
GH-800: refactor test stream_reader_shuts_down_when_it_receives_the_s…
d8d1f10 
…hutdown_signal
@utkarshg6
GH-800: some refactor inside the file stream_reader
ddf7d9c
@utkarshg6
GH-800: some more refactoring
a6f2538
@utkarshg6
GH-800: trying_to_write_a_test_for_stream_senders was a success
130a37c
@utkarshg6
GH-800: did some refactoring for trying_to_write_a_test_for_stream_se…
6db4c0c 
…nders
@utkarshg6
GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_t…
c3cc6a8 
…rue passes for the first time
@utkarshg6
GH-800: Minor refactor for the test stream_handler_pool_sends_shutdow…
75edd8f 
…n_signal_when_last_data_is_true
@utkarshg6
GH-800: more refactoring of the test stream_handler_pool_sends_shutdo…
296f449 
…wn_signal_when_last_data_is_true
@utkarshg6
GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_t…
a2c763d 
…rue is working fine
@utkarshg6
GH-800: some more todos removed
3c223ea
@utkarshg6
GH-800: clean_up_dead_streams_logs_when_the_shutdown_channel_is_down …
4605d83 
…is passing
@utkarshg6
GH-800: tests are passing in StreamHandlerPool
e1417c8
@utkarshg6
GH-800: Wrote a test for the case when the shutdown signal channel is…
6e28ff1 
… gone
@utkarshg6
GH-800: make it easier to understand who experiences the write error
6849db6
@utkarshg6
GH-800: trying to write test while_housekeeping_the_stream_senders_ar…
af09d25 
…e_received_by_stream_handler_pool
@utkarshg6
GH-800: add test add_new_streams_works
b896db6
@utkarshg6
GH-800: wip: add the log
acf2c89
@utkarshg6
GH-800: test proxy_client_stream_reader_dies_when_client_stream_is_ki…
deb1535 
…lled_integration is passing
@utkarshg6
GH-800: change the channel from crossbeam to tokio
2ecfebc
@utkarshg6
GH-800: Add fn send_shutdown_signal_to_stream_reader
3b387a7
@utkarshg6
GH-800: wip: fixing 2 tests
f94c8d3
utkarshg6 and others added 24 commits August 7, 2024 17:55
@utkarshg6
GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_t…
54040ae 
…rue is passing
@utkarshg6
GH-800: all tests in stream_handler_pool.rs are passing
31db7c4
@utkarshg6
GH-800: add test for the logs; all tests passing
4f8c141
@utkarshg6
GH-800: remove lookup_ip() mock fns from a test
1880006
@utkarshg6
GH-800: remove warnings
d81c2f0
@utkarshg6
GH-800: use fn send_shutdown_signal_to_stream_reader in clean_up_dead…
ae08930 
…_streams()
@utkarshg6
Revert "GH-800: use fn send_shutdown_signal_to_stream_reader in clean…
23fc9ab 
…_up_dead_streams()"

This reverts commit ae08930.
@utkarshg6
Revert "GH-800: remove warnings"
f9491e7 
This reverts commit d81c2f0.
@utkarshg6
Revert "GH-800: remove lookup_ip() mock fns from a test"
3e3fa71 
This reverts commit 1880006.
@utkarshg6
Revert "GH-800: add test for the logs; all tests passing"
d4e8075 
This reverts commit 4f8c141.
@utkarshg6
Revert "GH-800: all tests in stream_handler_pool.rs are passing"
5aa1107 
This reverts commit 31db7c4.
@utkarshg6
Revert "GH-800: stream_handler_pool_sends_shutdown_signal_when_last_d…
f2dbe7b 
…ata_is_true is passing"

This reverts commit 54040ae.
@utkarshg6
Revert "GH-800: wip: fixing 2 tests"
a24dcda 
This reverts commit f94c8d3.
@utkarshg6
Revert "GH-800: Add fn send_shutdown_signal_to_stream_reader"
c61cc5a 
This reverts commit 3b387a7.
@utkarshg6
Revert "GH-800: change the channel from crossbeam to tokio"
af9a673 
This reverts commit 2ecfebc.
@utkarshg6
GH-800: reverted the channel to crossbeam; remove warnings
5ba55df
@utkarshg6
GH-800: solve some TODOs
5579c12
@utkarshg6
GH-800: add refactored fn send_shutdown_signal_to_stream_reader; crti…
3f34e83 
…tical integration test passing
@utkarshg6
GH-800: write_failure_for_nonexistent_stream_generates_termination_me…
681a79f 
…ssage is improved
@utkarshg6
GH-800: everything is tested
0811b5e
@utkarshg6
GH-800: fix proxy_server_receives_terminal_response_from_hopper
d86918e
@utkarshg6
GH-800: trigger actions
53eadfa
@utkarshg6
GH-800: assert on a different error on non-mac os
74eb857
@utkarshg6
Merge branch 'master' into GH-800
92d46cd
utkarshg6
utkarshg6 commented Sep 11, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utkarshg6