-
Notifications
You must be signed in to change notification settings - Fork 123
add close_ggml_native feature #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm not sure if the feature is the way to go. I think hooking into cargo's --target-cpu is better. (this likely changes the default from native to something else) |
I tried running the executable on Windows using |
I don't think the build.rs script can pick up on the EDIT: |
|
A different, but related task is to support the This is the best of both worlds: maximum portability and performance. |
This is correct. Apologies for not being clear. I'd like
This would be interesting for sure. Given these exist, I wonder what the appropriate way to expose them would be. I'd be interested to see what consumers of this library (both apps and libs) would prefer. |
Adding the feature to disable GGML_NATIVE and enabling the close_ggml_native feature may result in a performance decrease, but it allows the executable to run on other computers.