Fix undefined behavior related to function pointer cast#184
Merged
utelle merged 1 commit intoutelle:mainfrom Dec 10, 2024
Koromix:fix_ub_function_pointer_cast
Merged
Fix undefined behavior related to function pointer cast#184utelle merged 1 commit intoutelle:mainfrom Koromix:fix_ub_function_pointer_cast
utelle merged 1 commit intoutelle:mainfrom
Koromix:fix_ub_function_pointer_cast
Conversation
Owner
|
Thanks for reporting the issue and providing a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting a function pointer to a different function pointer type is undefined behavior in C, and triggers UBSan as shown below:
This PR fixes this by changing the declaration of
sqlite3mcFreeCodecParameterTableto take avoid *pointer and avoid the cast entirely.