Skip to content

Embedded the java-api into the plugin jar #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Conversation

viniciusam
Copy link
Member

The generated artifact will have java-api code embedded and it won't be part of the final pom for the library, that way the users won't need to add the java-api to their private repos.
I also added ojdbc as a direct dependency, but I'm not sure if this will fix #23 as I couldn't test it locally.

@viniciusam viniciusam requested review from jgebal and pesse January 26, 2019 14:49
@adrianhj
Copy link

adrianhj commented Jun 7, 2019

With the license of the Oracle JDBC drivers, are we able to distribute these ourselves and still fit into Apache 2.0? Usual strategy for most products touching an Oracle database I've worked on has been a case of 'end-user needs to provide drivers or it affects our ability to manage our own license' unfortunately.

From my understanding redistribution of the JDBC drivers requires the consumer to agree to certain terms: https://www.oracle.com/technetwork/database/enterprise-edition/jdbc-faq-090281.html#02_12.

Probably safer to treat this as a provided dependency and document that the driver needs to be provided to the plugin (or continue as now and pull it in automatically through the java-api as a dependency in plugin.xml without packaging and including it directly).

@pesse
Copy link
Member

pesse commented Jun 7, 2019

Gerald Venzl dug into that about a year ago and his suggestion was to not ship any Oracle binaries or package them.

@jgebal jgebal merged commit b6d378e into develop Jul 13, 2019
@jgebal jgebal deleted the feature/embed-java-api branch July 13, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No suitable driver found for jdbc:oracle:thin: ...
4 participants