Improve hasOutput check to a real PL/SQL type-check #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Jacek for the hint! It's also less verbose now.
jgebal
reviewed
Jan 15, 2019
| " begin " + | ||
| " execute immediate '" + | ||
| " begin " + | ||
| " :x := case ' || ? || '() is of (ut_output_reporter_base) when true then 1 else 0 end;" + |
There was a problem hiding this comment.
I would keep dbms_assert.valid_sql_name call.
It's a build in function that checks object name valid and that it is visible to user.
It is far safer than regex check.
You can still have both
There was a problem hiding this comment.
See the failed attempts. It's problematic on 11g as it seems.
I'll give it one last try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Jacek for the hint!
It's also less verbose now.