Skip to content

#110 - Use local assets for code coverage report for offline usage #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 27, 2020
Merged

#110 - Use local assets for code coverage report for offline usage #120

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
167b943
add code coverage report assets v1.0.1
PhilippSalvisberg Dec 27, 2020
833bbad
add htmlReportAssetPath parameter to UtplsqlDao.htmlCodeCoverage()
PhilippSalvisberg Dec 27, 2020
a4f5942
add htmlReportAssetPath parameter to RealtimeReporterDao.produceRepor…
PhilippSalvisberg Dec 27, 2020
762b4ba
add optional htmlReportAssetPath field to UtplsqlRunner
PhilippSalvisberg Dec 27, 2020
89666ff
simplify code, remove unnecessary conditions
PhilippSalvisberg Dec 27, 2020
f254653
copy assets to temporary directory on instantiation of CodeCoverageRe…
PhilippSalvisberg Dec 27, 2020
4d98053
check for local assets in CodeCoverageReporterTest
PhilippSalvisberg Dec 27, 2020
31464af
change call parameters and check for default assets (via internet)
PhilippSalvisberg Dec 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add htmlReportAssetPath parameter to RealtimeReporterDao.produceRepor… 
…tWithCoverage()
  • Loading branch information
@PhilippSalvisberg
PhilippSalvisberg committed Dec 27, 2020
commit a4f59429284d534c9adbecd3580ebf68abc07f2e
7 changes: 4 additions & 3 deletions sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import java.io.IOException;
import java.io.StringReader;
import java.net.URL;
import java.sql.Clob;
import java.sql.Connection;
import java.sql.ResultSet;
Expand Down Expand Up @@ -108,11 +109,11 @@ public void produceReport(final String reporterId, final List<String> pathList)

public void produceReportWithCoverage(final String realtimeReporterId, final String coverageReporterId,
final List<String> pathList, final List<String> schemaList, final List<String> includeObjectList,
final List<String> excludeObjectList) {
final List<String> excludeObjectList, final URL htmlReportAssetPath) {
StringBuilder sb = new StringBuilder();
sb.append("DECLARE\n");
sb.append(" l_rt_rep ut_realtime_reporter := ut_realtime_reporter();\n");
sb.append(" l_cov_rep ut_coverage_html_reporter := ut_coverage_html_reporter();\n");
sb.append(" l_cov_rep ut_coverage_html_reporter := ut_coverage_html_reporter(a_html_report_assets_path => ?);\n");
sb.append("BEGIN\n");
sb.append(" l_rt_rep.set_reporter_id(?);\n");
sb.append(" l_rt_rep.output_buffer.init();\n");
Expand Down Expand Up @@ -143,7 +144,7 @@ public void produceReportWithCoverage(final String realtimeReporterId, final Str
sb.append(" sys.dbms_output.disable;\n");
sb.append("END;");
final String plsql = sb.toString();
final Object[] binds = { realtimeReporterId, coverageReporterId };
final Object[] binds = { htmlReportAssetPath == null ? null : htmlReportAssetPath.toExternalForm(), realtimeReporterId, coverageReporterId };
jdbcTemplate.update(plsql, binds);
}

Expand Down