-
Notifications
You must be signed in to change notification settings - Fork 10
Pre Release (v3.5.0-beta.1): UTL cmd のテストを追加する #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
全然急ぎではないです。 |
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
#184 がマージされたので,念の為rebaseしておいたほうが良さそう.(rebaseしないと,SILSが動かない気がする?) |
ba666f9
to
b3fcfef
Compare
b3fcfef
to
ff3afe7
Compare
utl_cmd の実行引数を TI ベースで計算していたので分かりにくくなっていたのですが、unixtime ベースに直したらだいぶマシになりました。 |
time_manager.c で例外処理が抜けている箇所を一つ見つけてしまったので、このPRでまとめて修正したいと思います |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全体的に良さそう!
細かい話入れてます.
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
...minimum_user_for_s2e/src/src_user/Test/test/src_core/System/TimeManager/test_time_manager.py
Outdated
Show resolved
Hide resolved
@meltingrabbit !!!!!!!!!!!!!!!!!!!!!!! Toolsの互換性が失われるPRなので,最後にバージョン上げること!!! !!!!!!!!!!!!!!!!!!!!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
概要
UTL_cmd のpytestを追加した
Issue
詳細
TMGR のテストに UTL_cmd が正しく打てるかどうかの確認を追加した。
検証結果
作成したpytestが通った
影響範囲
小
補足
python-wings-if側のPRの検証にもなっている