This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added changelog - start work on upgrade doc to cover v2 -> v3
* wow- tons of external contributors for this release, love it!
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 40.57% 40.57%
=======================================
Files 25 25
Lines 870 870
=======================================
Hits 353 353
Misses 486 486
Partials 31 31
|
Before we merge @uswitch/cloud it'd be good to set the date- either today or tomorrow ;) |
This PR includes documentation necessary to close #117 |
rename prometheus histogram metrics to clarify units two metrics were tracking times of operations in seconds but the metric name implies it was milliseconds. * kiam_metadata_handler_latency_milliseconds * kiam_sts_assumerole_timing_milliseconds
This includes commits to address #187 |
Joseph-Irving
previously approved these changes
Dec 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- add quay badge - put today's date in the changelog
Joseph-Irving
approved these changes
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the prelim work ahead of release v3.0 of Kiam.