Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

V3 release #195

Merged
merged 10 commits into from
Dec 6, 2018
Merged

V3 release #195

merged 10 commits into from
Dec 6, 2018

Conversation

pingles
Copy link
Contributor

@pingles pingles commented Dec 6, 2018

This PR sets up the prelim work ahead of release v3.0 of Kiam.

  • Changelog
  • Upgrade notes

- added changelog
- start work on upgrade doc to cover v2 -> v3
* wow- tons of external contributors for this release, love it!
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   40.57%   40.57%           
=======================================
  Files          25       25           
  Lines         870      870           
=======================================
  Hits          353      353           
  Misses        486      486           
  Partials       31       31
Impacted Files Coverage Δ
pkg/aws/sts/metrics.go 100% <ø> (ø) ⬆️
pkg/aws/metadata/metrics.go 100% <ø> (ø) ⬆️

@pingles
Copy link
Contributor Author

pingles commented Dec 6, 2018

Before we merge @uswitch/cloud it'd be good to set the date- either today or tomorrow ;)

@pingles
Copy link
Contributor Author

pingles commented Dec 6, 2018

This PR includes documentation necessary to close #117

rename prometheus histogram metrics to clarify units
two metrics were tracking times of operations in seconds
but the metric name implies it was milliseconds.
* kiam_metadata_handler_latency_milliseconds
* kiam_sts_assumerole_timing_milliseconds
@pingles
Copy link
Contributor Author

pingles commented Dec 6, 2018

This includes commits to address #187

Joseph-Irving
Joseph-Irving previously approved these changes Dec 6, 2018
Copy link
Contributor

@Joseph-Irving Joseph-Irving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- add quay badge
- put today's date in the changelog
@pingles pingles merged commit a069095 into master Dec 6, 2018
@pingles pingles deleted the v3-release branch December 6, 2018 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants