Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

README: Note that primary ENI isn't always eth0 #169

Open
ewbankkit opened this issue Oct 26, 2018 · 3 comments
Open

README: Note that primary ENI isn't always eth0 #169

ewbankkit opened this issue Oct 26, 2018 · 3 comments

Comments

@ewbankkit
Copy link

We should update the README to note that the primary ENI isn't always eth0 (e.g. for instances with enhanced networking or running newer CentOS/RHEL, see discussion: aws/amazon-vpc-cni-k8s#171, aws/amazon-vpc-cni-k8s#190, aws/amazon-vpc-cni-k8s#193), calling out the case of negative prefixes introduced in #54,
Also, given that the primary ENI is kind of non-deterministic, maybe we could have a logical host-interface value like not-the-primary-eni (just a strawman 😄) that could be converted to the correct IPTables expression at runtime?

@pingles
Copy link
Contributor

pingles commented Nov 1, 2018

Interesting. Could you add a few more examples of what the flags would look like?

I quite like the idea of something that could specify --cni=calico etc. that'd take away some of the pain, or try and autodetect it from the metadata, but I feel like that should probably be in addition to allowing operators to specify the expression.

There's definitely been more than a few issues created where people hadn't expected to need to configure it so having something to reduce the surprise would be good.

@ewbankkit
Copy link
Author

Yes, a --cni flag with values such as awsvpc, calico, weave etc. could be added.
The --host-interface flag would of course still be supported for those cases where there was no corresponding cni value.

@pingles
Copy link
Contributor

pingles commented Nov 1, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants