Cleanup notification observers #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfish
added a commit
that referenced
this pull request
Jul 30, 2012
Cleanup notification observers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a crash which I could only explain by not removed text field notification observers in the US2FormValidator. In any case it is good practice to clean up afterwards.
0 CoreFoundation 0x34dfe88f exceptionPreprocess + 162
1 libobjc.A.dylib 0x36dcc259 objc_exception_throw + 32
2 CoreFoundation 0x34e01a9b -[NSObject doesNotRecognizeSelector:] + 174
3 CoreFoundation 0x34e00915 __forwarding + 300
4 CoreFoundation 0x34d5b650 _CF_forwarding_prep_0 + 48
5 Foundation 0x336354ff __57-[NSNotificationCenter addObserver:selector:name:object:]_block_invoke_0 + 18
6 CoreFoundation 0x34dca547 ___CFXNotificationPost_block_invoke_0 + 70
7 CoreFoundation 0x34d56097 _CFXNotificationPost + 1406
8 Foundation 0x335a93eb -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
9 Foundation 0x335aac1b -[NSNotificationCenter postNotificationName:object:] + 30
10 UIKit 0x314aaa3b -[UITextField fieldEditorDidChange:] + 278