Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up framework settings to allow unit tests to run #39

Merged
merged 1 commit into from
Apr 29, 2014

Conversation

grgcombs
Copy link

Some of the settings in the framework project were preventing unit tests from running. In particular, there was a derived data search path that was specific to the build environment at ustwo. I also cleaned up some of the compiler warnings and conflicting build settings between the library target and the unit test target, as well as added the XCTest.framework to the unit test target's linker.

@alexfish
Copy link
Contributor

thanks 👍

A nicer way to suppress the protocol warnings would be to add a compiler flag like so in the compile sources

image

@grgcombs
Copy link
Author

That's a great flag, I hadn't used that one before, thanks!

I think the main purpose of the commit was to take care of this path that was hard-coded to one found in (your?) development environment and resulted in an inability to link for unit tests.

""$(SRCROOT)/../../../Library/Developer/Xcode/DerivedData/US2FormValidationFramework-dbiegtxisormauhjwlitbbkypdsr/Build/Products/Debug-iphonesimulator"",

Everything else was really geared towards warnings.

@alexfish
Copy link
Contributor

Yeah sure, must have been dragged into the project to add the framework, thanks for fixing.

If you update that protocol fix I can merge in your PR

…s build environment. Also added compiler flag to remove a protocol warning on ValidatorUnitTests.m (thanks for the pointer!)
@grgcombs
Copy link
Author

All fixed up now in 8af1f1b. Thanks for the tip for the compiler flag!

alexfish added a commit that referenced this pull request Apr 29, 2014
Cleaned up framework settings to allow unit tests to run
@alexfish alexfish merged commit df53247 into ustwo:light-arc Apr 29, 2014
@alexfish
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants