Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Schematron rules in view of ongoing changes to sp800-53 catalog content #230

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Updating Schematron rules in view of ongoing changes to sp800-53 catalog content #230

merged 1 commit into from
Dec 14, 2023

Conversation

wendellpiez
Copy link
Contributor

@wendellpiez wendellpiez commented Dec 12, 2023 •
edited
Loading

Committer Notes

While not heavily tested, these Schematrons do detect a range of errors and inconsistencies in data. This PR reduces noise from inapplicable tests that would make them more or less useless to future users.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@wendellpiez wendellpiez mentioned this pull request Dec 13, 2023
Merged
10 tasks
JustKuzya
JustKuzya approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@JustKuzya JustKuzya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could extend "o:reduce-label" function with context, but that's a task for another day. It positively would call for more parameters, and context assertions in tests.

@iMichaela iMichaela merged commit b66ca2c into usnistgov:224_226_227_imichaela_patch_1.1.3 Dec 14, 2023
1 check passed
iMichaela added a commit that referenced this pull request Dec 15, 2023
@iMichaela @wendellpiez
Addresses bugs in 800-53 catalog (issues 224 226 227 for OSCAL conten…
e0a8319 
…t patch 1.2.1 (#228)

* addressed issue 226: error in IA-13(03)

* addresses issue 227 by removing extra related links in IA-13(01)(02)(03)

* addresses issue 229 by using consistent structure for the IA-13 ODP params

* updated metadata and backmater to include a link to the CPRT SP800-53v5.1.1 resource

* addresses issue 224 by replacing labels with alt-identifies and adding leading zeros to accurately reflect the SP800-53 v5.1.1 release.

* updated root uuid, last-modified, revision history and back-matter.

* added leading zero to PM-7, PM-8 and PM-9 which were missing.

* fix the errors identified during the Schematron validation

* updated one more time the last modified and the uuid

* Updating Schematron rules in view of ongoing changes. (#230)

---------

Co-authored-by: Iorga <miorga@pn129618.campus.nist.gov>
Co-authored-by: Wendell Piez <wendell.piez@nist.gov>
@iMichaela iMichaela mentioned this pull request Dec 15, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddendragonXVII hiddendragonXVII hiddendragonXVII left review comments

@JustKuzya JustKuzya JustKuzya approved these changes

@iMichaela iMichaela iMichaela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wendellpiez @hiddendragonXVII @JustKuzya @iMichaela