Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[script]: Unify base64 result output with the rest of the results #414

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

mgajdar
Copy link
Contributor

@mgajdar mgajdar commented Aug 28, 2024

No description provided.

@mgajdar mgajdar marked this pull request as ready for review August 28, 2024 07:42
@brodjieski
Copy link
Collaborator

I like the idea of matching the output format for the base64 results. Rather than having it be a dictionary, I think it would be better to just store the value of the result. This would better align with the other results. So instead of result['base64'] = {result_value} maybe just do result['base64'] = result_value?

Also, there is an outstanding item I've been meaning to tackle, and if you'd like to include it with your change, that would be awesome. The log for the base64 expected results is being forced to lowercase, which make the value incorrect in the log output. If you want to remove the lower() call in line 997, that would be a bonus ;)

@mgajdar mgajdar force-pushed the fix_base64_result branch from e06410b to 461ddc2 Compare August 29, 2024 12:10
@brodjieski brodjieski changed the base branch from main to dev_sequoia September 11, 2024 17:08
@brodjieski brodjieski changed the base branch from dev_sequoia to main September 11, 2024 17:08
@brodjieski brodjieski changed the base branch from main to sonoma September 11, 2024 17:21
@brodjieski brodjieski changed the base branch from sonoma to dev_sequoia September 11, 2024 17:23
@brodjieski brodjieski merged commit d18b518 into usnistgov:dev_sequoia Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants