Skip to content

Fix test configs and utils#2712

Merged
DavyLandman merged 7 commits intomainfrom
fix/test-configs-and-utils
Mar 16, 2026
Merged

Fix test configs and utils#2712
DavyLandman merged 7 commits intomainfrom
fix/test-configs-and-utils

Conversation

@toinehartman
Copy link
Member

  • Remove import of test configs from main Checker module.
  • Fix inconsistencies in test path configs.
  • Re-use code in testing utils.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46%. Comparing base (3e0ccc6) to head (45d8fc6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2712   +/-   ##
=======================================
  Coverage       46%     46%           
- Complexity    6679    6680    +1     
=======================================
  Files          795     795           
  Lines        65905   65905           
  Branches      9881    9881           
=======================================
+ Hits         30716   30722    +6     
- Misses       32804   32805    +1     
+ Partials      2385    2378    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@toinehartman toinehartman marked this pull request as ready for review March 13, 2026 14:38
@toinehartman toinehartman requested a review from PaulKlint March 13, 2026 14:38
@toinehartman
Copy link
Member Author

@PaulKlint This PR is mostly intended to remove the test code from the checker at runtime. I'll launch an integration test to make sure this does not introduce any unwanted side effects.

@toinehartman
Copy link
Member Author

toinehartman commented Mar 16, 2026

@sonarqubecloud
Copy link

@DavyLandman DavyLandman merged commit 18f108f into main Mar 16, 2026
9 checks passed
toinehartman added a commit that referenced this pull request Mar 18, 2026
* Do not import test configs in production.

* Consistent test config paths.

* Whitespace.

* Reuse.

* Import test configs in test utils.

* Add imports where needed.

* Add another missing import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants