-
Notifications
You must be signed in to change notification settings - Fork 82
No longer wrapping complex types in an auxiliary JSON object #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rodinaarssen
wants to merge
13
commits into
main
Choose a base branch
from
fix-jsonrpc-wrapping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6623 6640 +17
=======================================
Files 793 793
Lines 65638 65695 +57
Branches 9831 9840 +9
=======================================
+ Hits 30480 30513 +33
- Misses 32804 32827 +23
- Partials 2354 2355 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…JSON (de)serialization
The test for `set`s is currently failing
The test for `rat`s is currently failing
The test for `rat`s and all non-primitive values are currently failing
The test for `rat`s is currently failing
a4564b5 to
3e22617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex types were wrapped in an auxiliary object to avoid ambiguities between the JSON representation of containers and "lists as a sole argument" on the JSON-RPC level. This is not necessary, as complex types are not automatically deserializable through this path anyway. This PR removes wrapping around complex types, leaving rationals as the only values that are wrapped when encoding values as JSON objects.
FIxes usethesource/rascal-language-servers#944