Error while logging in with "Remember me" using Postgres

[RomeroMsk]

With Postgres as database driver I'm having an issue when trying to log in with "Remember me" checked:

UserFrosting Application Error
The application could not run because of the following error:

Details

Type: PDOException
Code: 42883
Message: SQLSTATE[42883]: Undefined function: 7 ERROR: function sha1(unknown) does not exist LINE 1: ..., token, persistent_token, expires_at) VALUES($1, SHA1($2), ... ^ HINT: No function matches the given name and argument types. You might need to add explicit type casts.
File: .../app/vendor/birke/rememberme/src/Rememberme/Storage/PDO.php
Line: 58

So, using this library (gbirke/rememberme) makes UserFrosting database dependent.

Any chances to get a fix/workaround for this?

[alexweissman]

Does Postgres not support SHA1? Is it possible that there is some extension that you need to install?

[RomeroMsk]

There is no such function in PostgreSQL, unfortunately. The only way I've found is ENCODE(DIGEST(..., 'sha1'), 'hex'), but it requires cryptographic libraries to be installed for Postgres.

[Silic0nS0ldier]

Hmm. Looking at the source code, it has raw SQL queries. Wouldn't surprise me if this had issues on other dbms too.

[RomeroMsk]

Yep, the code of this library doesn't seem to be DB agnostic.

[alexweissman]

If we can find a pre-existing implementation of improved persistent login for Eloquent, I'd be fine if someone wants to work on replacing the gbirke library. Otherwise, we may have to implement our own version.

[RomeroMsk]

I think the easiest way to fix this will be own implementation of PDO storage class for gbirke/rememberme library:

1. Create a corresponding PHP script in app/sprinkles/account/src dir.
2. Copy the existing code from vendor/birke/rememberme/src/Rememberme/Storage/PDO.php and replace all SHA1() in SQL queries with PHP sha1() function calls.
3. Use this new file in UserFrosting\Sprinkle\Account\Authenticate\Authenticator class instead of Birke\Rememberme\Storage\PDO.

[alexweissman]

Did you see this commit: gbirke/rememberme#20 (comment) ?
Not sure if that solves the problem with Postgres as well.

My recommendation would be to fork @gbirke's repo, make the changes, and then submit a PR. He seems pretty willing to merge PRs as long as they adhere to standards and pass unit tests. It would be simpler than for us to try and maintain a separate fork.

[RomeroMsk]

I didn't see this commit itself yet, but I saw this solution with custom SHA1 function before. Unfortunately, it requires an additional Postgresql module to be installed. I'm going to check it when I will be able to get this module installed.
But anyways it is still a compatibility issue that makes your product DB dependent ;)

[alexweissman]

Maybe leave a comment on that commit? Ask them why they didn't just use PHP's sha1 function instead?

[RomeroMsk]

There is an issue already (from me): gbirke/rememberme#19
It was mentioned in that comment, btw.

[gbirke]

The history why I do the hashing in SQL instead of PHP is a bit hazy (that was 2-3 years ago), I dimly remember having problems writing a unit test and then settling on doing it in SQL because it was the easiest. At the moment I have no spare time to change it, but if anyone supplies a patch, I'll gladly merge it and release a new version of the library.

[RomeroMsk]

Well, to test a patch with UF we need to bump the version of gbirke/rememberme used in UF to the latest one.