Merged
Conversation
Owner
|
Yeah, I will add more benchmarks later. After enabling the pooling, AsyncKeyedLock is slower than ImageSharpWeb. I think the main reason for pooling is to get a better performance and not to reduce memory. That's why all frameworks enable this feature per default. |
Contributor
Author
The main reason for the polling in AsyncKeyedLock is to reduce memory allocations. In the benchmarks I did, it also improved performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way you are benchmarking currently doesn't cater for multi-threading or contention. I didn't want to change such tests; however, I did amend the benchmark for my library to use the pooling (which by default is disabled) and you will be able to notice the big difference in the memory allocations.