Skip to content

Conversation

till-a
Copy link

@till-a till-a commented Nov 22, 2023

Works for

  • collection operations
  • class members
  • use-commands

Note: Autocompletion is currently integrated into the EvalOCLDialog only and not into the shell.
As a result, only collection operations and class members are fully supported.

Copy link
Contributor

@h-man2 h-man2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great: you implemented many tests 👍

Empty classes could possibly be replaced by interfaces, but this is a minor issue.

Would be great to accept suggestions by pressing <enter>.
Reducing the suggested entries while typing would improve teh usabilty, too!

});

autocompletionScrollPane = new JScrollPane(autocompletionResultList);
textPane.add(autocompletionScrollPane, 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to place the autocompletion windows at the position of the caret? Maybe by using another JFrame? This way it would work more like other auto completion, improving usability,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good idea. Since 06c5b06 the auto completion windows depend on the caret position and the prefix already present in the input text area. In my opinion, this resolves the issue effectively.

till added 5 commits December 8, 2023 12:47
@till-a
Copy link
Author

till-a commented Dec 9, 2023

Would be great to accept suggestions by pressing <enter>.
Reducing the suggested entries while typing would improve teh usabilty, too!

Both of these should work in 9739f1d as the suggestions are now dynamically updated with every written character. To move through the suggested list the ArrowDown and ArrowUp keys can be used (also see documentation/documentation.md for keybinds).

Fixxed nullpointer when there were no suggestions
Changed suggestion behaviour for = statements
@ichxorya
Copy link
Collaborator

May I ask how's the update going, since it's nearly a year from your last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants