Open
Conversation
2b6b987 to
47d9414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
this_day()CEL filter function that matches memos created on today's month-day in any year. Supports all three database dialects (SQLite, MySQL, PostgreSQL).Changes
ThisDayConditionIR node in the filter pipeline.this_dayas a zero-arg boolean CEL function in the memo schema.this_day()calls intoThisDayConditionin the filter parser.created_tsmonth-day against current date for SQLite, MySQL, and PostgreSQL.CreatedTsbuilder method to test helpers for setting custom creation timestamps.Usage
Related Issue
Resolves #5633
Testing
Manual
this_day()in the Filter field and save it.Automated
TestMemoFilterThisDay- matches today + same day last year, excludes different day.TestMemoFilterThisDayCombinedWithOtherFilters- combines with tag filter.TestMemoFilterThisDayNoMatches- only different-day memos, expects 0 results.TestMemoFilterThisDayNegated- verifies!this_day()negation.