fix: resolve locale for logged-out visitors from browser/localStorage#5634
Open
bakill3 wants to merge 1 commit intousememos:mainfrom
Open
fix: resolve locale for logged-out visitors from browser/localStorage#5634bakill3 wants to merge 1 commit intousememos:mainfrom
bakill3 wants to merge 1 commit intousememos:mainfrom
Conversation
2b6b987 to
47d9414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Logged-out visitors always see English because
useUserLocalereturned early whenuserGeneralSettingwas undefined, andi18n.init()had no lng set (thedetectionconfig referenced a plugin that was never loaded).Fix:
i18n.ts:resolve initial locale at module load (query param → localStorage →navigator.languages→ "en") so the first render is correct.useUserLocale.ts: remove early return → rungetLocaleWithFallback()for all users.utils/i18n.ts: addnormalizeLocale()helper, query param support, andnavigator.languagesiteration.Locale priority (both logged-in and logged-out):
?locale=xxquery parameterlocalStorage("memos-locale")navigator.languages"en"