Fix gRPC crash when memo content contains invalid UTF-8#5401
Open
ManakRaj-7 wants to merge 1 commit intousememos:mainfrom
Open
Fix gRPC crash when memo content contains invalid UTF-8#5401ManakRaj-7 wants to merge 1 commit intousememos:mainfrom
ManakRaj-7 wants to merge 1 commit intousememos:mainfrom
Conversation
Add defensive UTF-8 validation in convertMemoFromStore to prevent gRPC marshal failures when memo content or derived snippet contains invalid UTF-8 data. This fails fast with a clear INTERNAL error instead of crashing the Listen response. Signed-off-by: Manak Raj <7manakraj@gmail.com>
boojack
force-pushed
the
main
branch
2 times, most recently
from
a196c72 to
71e8a06
Compare
boojack
force-pushed
the
main
branch
2 times, most recently
from
2b6b987 to
47d9414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5392
Problem
ListMemoscan fail with:grpc: error while marshaling: string field contains invalid UTF-8when stored memo content or derived snippet contains invalid UTF-8 data.This causes the entire API response to fail during protobuf marshaling.
Solution
Add defensive UTF-8 validation in
convertMemoFromStorebefore constructing protobuf responses.If invalid UTF-8 is detected:
Scope
Notes
This is a diagnostic-first fix to improve API stability and observability.