Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use UTC date for calendar filter #4046

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

RoccoSmit
Copy link
Contributor

As per issue: #2765 (comment)

Memos are stored with a UTC timestamp. When the calendar dates are selected the UTC offset is not used to create the timestamps between which the memo creation date should fall.

e.g. of incorrect memos being shown
image
image
image

This PR aims to include the UTC offset in filter dates

e.g. of correct memos being shown
image
image
image

@RoccoSmit RoccoSmit requested a review from boojack as a code owner October 23, 2024 13:33
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack changed the title Use UTC date for calendar filter fix: use UTC date for calendar filter Oct 23, 2024
@boojack boojack merged commit 2851f11 into usememos:main Oct 23, 2024
2 checks passed
@RoccoSmit RoccoSmit deleted the utc-calendar-filter branch October 23, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants