Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iframe rendering #3916

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: iframe rendering #3916

merged 2 commits into from
Sep 12, 2024

Conversation

ti777777
Copy link
Contributor

@ti777777 ti777777 commented Sep 11, 2024 •
edited
Loading

By default, DOMPurify removes the content of iframe, but I think iframe is a commonly used tag

@ti777777 ti777777 requested a review from boojack as a code owner September 11, 2024 20:22
@ti777777 ti777777 closed this Sep 11, 2024
@ti777777 ti777777 reopened this Sep 11, 2024
@boojack boojack changed the title fix iframe rendering fix: iframe rendering Sep 12, 2024
boojack
boojack approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 6f3d576 into usememos:main Sep 12, 2024
2 checks passed
@xhocquet
Copy link
Contributor

Thanks for this fix, just ran into the bug and was wondering why I couldn't see the issue on main's code!

@ti777777 ti777777 deleted the ti777777-fix-iframe-tag branch September 13, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti777777 @xhocquet @boojack