fix: load server name and icon from settings #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojack
reviewed
Sep 10, 2024
Comment on lines
+24
to
+27
| const workspaceGeneralSetting = | ||
| workspaceSettingStore.getWorkspaceSettingByKey(WorkspaceSettingKey.GENERAL).generalSetting || WorkspaceGeneralSetting.fromPartial({}); | ||
| const title = user ? user.nickname || user.username : workspaceGeneralSetting.customProfile?.title; | ||
| const avatarUrl = user ? user.avatarUrl : workspaceGeneralSetting.customProfile?.logoUrl; |
There was a problem hiding this comment.
Suggested change
| const workspaceGeneralSetting = | |
| workspaceSettingStore.getWorkspaceSettingByKey(WorkspaceSettingKey.GENERAL).generalSetting || WorkspaceGeneralSetting.fromPartial({}); | |
| const title = user ? user.nickname || user.username : workspaceGeneralSetting.customProfile?.title; | |
| const avatarUrl = user ? user.avatarUrl : workspaceGeneralSetting.customProfile?.logoUrl; | |
| const workspaceGeneralSetting = | |
| workspaceSettingStore.getWorkspaceSettingByKey(WorkspaceSettingKey.GENERAL).generalSetting || WorkspaceGeneralSetting.fromPartial({}); | |
| const title = user ? user.nickname || user.username : workspaceGeneralSetting.customProfile?.title; | |
| const avatarUrl = user ? user.avatarUrl : (workspaceGeneralSetting.customProfile?.logoUrl || "/full-logo.webp") ; |
boojack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the saved server name and icon to unregistered users viewing the explore page as per issue #3904
Testing:
Fresh signup page
Setting only server name
Signin page with new server name and default image
Explore page when unregistered without icon set
Setting server icon
Signin page with new server name and icon
Explore page when unregistered with icon set
