-
Couldn't load subscription status.
- Fork 12
feat: specify base images to refresh on deploy #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad37826 to
9fc0c76
Compare
9fc0c76 to
ad37826
Compare
shreddedbacon
requested changes
Aug 19, 2024
shreddedbacon
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solves the problem neatly, but also in a way that allows for expansion in the future if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if one chooses to implement a base image solution -- that is, most of one's code being bundled in an upstream image shared by multiple projects/environments -- there is an issue with caching.
If the base image, say,
container.reg/my/baseimage:latest, or indeed, anything that isn't injected explicitly into the build, the image is cached by the docker-host, and if you make changes to the upstream image, butcontainer.reg/my/baseimage:latestis currently in the docker-host's cache, it's not going to pull the new upstream image.This small change allows users to explicitly mark their services as using a base image, and specifying what the name of that image is via an optional label
lagoon.base.image.This leads to, for example, service definitions that look like so:
On finding the label, the build-deploy-tool with attempt to pull the upstream image, which it will do if there have been updates.