Skip to content

Conversation

@sanjaysrikakulam
Copy link
Member

Xref: https://github.com/usegalaxy-eu/issues/issues/754

This PR is part of the migration. Once the sn11 migration has happened, we should merge this PR and deploy the CIs.

@bgruening
Copy link
Member

Q: should this postgresql server be its own variable, is that possible, so we only need to update it in one place?

@sanjaysrikakulam
Copy link
Member Author

Q: should this postgresql server be its own variable, is that possible, so we only need to update it in one place?

Yes, this is possible but needs a bit more through look up. We can add a db_server_host: sn11.galaxyproject.eu to our group_vars/all.yml and then reference this variable and at the same time we should ensure that all the corresponding playbooks include the group_vars/all.yml.

Maybe in the next days I can look into this in detail after the migration and deployments.

Copy link
Contributor

@sj213 sj213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are straightforward and obvious and all look ok, but since I'm not too familiar with Galaxy's inner workings I couldn't rly tell if a change for some service was missing. With this cautioning remark, I approve.

@sanjaysrikakulam
Copy link
Member Author

The vault needs to be updated. I will push a new commit shortly.

@sj213
Copy link
Contributor

sj213 commented Jul 25, 2025

And wrt making the postgres server host a global configuration parameter: Good idea; we could even to one step further and also make the PG TCP port a config parameter that is referenced by every service using PG. While I cannot right now think of a scenario where running two PG clusters on the same host would be a thing, for the future one never knows. It might one day come in handy for testing migration to a new major version or something...

@sanjaysrikakulam
Copy link
Member Author

We definitely should migrate to variable-based. It's just in too many places. I hope I caught it all.

@bgruening bgruening merged commit 32fe34d into usegalaxy-eu:master Jul 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants