Convert markdown content in LinkedIn #69
Conversation
lib/plugins/linkedin.py
Outdated
| if len(images) > 20: | ||
| warnings = f"A maximum of 20 images, not {len(images)}, can be included in a single linkedin post." | ||
| images = images[:20] | ||
| else: | ||
| warnings = "" | ||
|
|
||
| # convert markdown formatting because Mastodon doesn't support it |
There was a problem hiding this comment.
should this be a shared function in both classes?
There was a problem hiding this comment.
Should I create a function in galaxy_social.py to be used by plugins?
There was a problem hiding this comment.
What do you think about the new commit?
|
I guess it's time for a client base class that ships as a default plugin and defines the method? |
|
That class could also raise NotImplemented for format_content and create_post, i.e. enforce that derived client classes define these methods. |
|
So should I just revert the change to have a simple code for the conversion of LinkedIn content and work on the client base class later? |
|
Sounds good from my side, yes. |
|
Ready for review @wm75 |
|
Had an idea for a simpler implementation, but you've worked out everything that's required @arash77 ! |
Same as #58