Skip to content

Conversation

@shubh-bruno
Copy link
Collaborator

@shubh-bruno shubh-bruno commented Jan 23, 2026

Description

PR fix : #6910

This pr fixes below things regarding GQL requests

  1. Response pane actions visible in response
  2. Save Example of response
  3. Show examples inside requests in collection drop-down

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • New Features
    • GraphQL request support expanded: Response bookmarks, pane actions, and example management now work with GraphQL requests in addition to HTTP requests, providing unified functionality across both request types.
    • Enhanced response pane: All response-related features now consistently support both HTTP and GraphQL queries, enabling streamlined workflows for comprehensive API testing and improving overall usability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Walkthrough

The changes extend visibility and rendering conditions across three UI components to include GraphQL requests alongside HTTP requests. Type-checking logic in ResponseBookmark, ResponsePaneActions, and CollectionItem components is modified to recognize both 'http-request' and 'graphql-request' types.

Changes

Cohort / File(s) Change Summary
ResponsePane Components
packages/bruno-app/src/components/ResponsePane/ResponseBookmark/index.js, packages/bruno-app/src/components/ResponsePane/ResponsePaneActions/index.js
Extended type filter conditions to include 'graphql-request' alongside 'http-request', broadening the visibility and rendering of bookmark and action elements.
Sidebar Collection Components
packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/index.js
Updated hasExamples logic and UI rendering to show example indicators for GraphQL requests in addition to HTTP requests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno
  • bijin-bruno

Poem

GraphQL joins the party line,
ResponsePane elements align,
Examples now shine bright and clear,
For queries and mutations here! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix: response pane actions for GQL requests' clearly and specifically describes the main change, which is enabling response pane actions for GraphQL requests across three components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/index.js (1)

371-378: Inconsistency: 'Create Example' menu item excludes GraphQL requests.

The context menu's "Create Example" option is still restricted to http-request only, while the PR enables saving examples from the response pane for both HTTP and GraphQL. This creates a UX inconsistency where GraphQL users can save response examples but cannot create empty examples from the context menu.

Consider aligning this with the other changes:

Suggested fix
-    if (!isFolder && isItemARequest(item) && item.type === 'http-request') {
+    if (!isFolder && isItemARequest(item) && (item.type === 'http-request' || item.type === 'graphql-request')) {
       items.push({
         id: 'create-example',
         leftSection: ExampleIcon,
         label: 'Create Example',
         onClick: () => setCreateExampleModalOpen(true)
       });
     }

@shubh-bruno shubh-bruno changed the title fix/response pane actions for GQL requests fix: response pane actions for GQL requests Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No more actions on the GraphQL response

1 participant