-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: response pane actions for GQL requests #6911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes extend visibility and rendering conditions across three UI components to include GraphQL requests alongside HTTP requests. Type-checking logic in ResponseBookmark, ResponsePaneActions, and CollectionItem components is modified to recognize both 'http-request' and 'graphql-request' types. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/index.js (1)
371-378: Inconsistency: 'Create Example' menu item excludes GraphQL requests.The context menu's "Create Example" option is still restricted to
http-requestonly, while the PR enables saving examples from the response pane for both HTTP and GraphQL. This creates a UX inconsistency where GraphQL users can save response examples but cannot create empty examples from the context menu.Consider aligning this with the other changes:
Suggested fix
- if (!isFolder && isItemARequest(item) && item.type === 'http-request') { + if (!isFolder && isItemARequest(item) && (item.type === 'http-request' || item.type === 'graphql-request')) { items.push({ id: 'create-example', leftSection: ExampleIcon, label: 'Create Example', onClick: () => setCreateExampleModalOpen(true) }); }
Description
PR fix : #6910
This pr fixes below things regarding GQL requests
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.