Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Docker build arm images as well... #932

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Conversation

cpolzer
Copy link
Contributor

@cpolzer cpolzer commented Jun 1, 2023

Hello,

working on my ARM Macbook, i quickly discoverd that the sphinx-needs docker image is not usable , for example as a devcontainer in VSCode.

In context of the sphinx docker pipeline, i thought this might be the correct solution, but was not able to test it as the main branch build is not working out of the box within my fork.

Anyhow, I hope we somehow get enabled to consume arm based docker images.

Regards!

@danwos
Copy link
Member

danwos commented Jun 4, 2023

Thanks for the PR.
Have no access to an ARM system, but the change looks promising. So let's take it :)

@danwos danwos merged commit 8d01312 into useblocks:master Jun 4, 2023
@cpolzer
Copy link
Contributor Author

cpolzer commented Jun 12, 2023

@danwos Would we need to have some kind of dry run build (without push) for the docker images? Just for changes on our docker workflow and the dockerfiles maybe?

@danwos
Copy link
Member

danwos commented Jun 22, 2023

Not sure, as I'm not a docker expert and don't know what a good docker-testing setup should look like.
But I'm totally open to it and don't see any arguments why not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants