-
Notifications
You must be signed in to change notification settings - Fork 81
✨ Add needs_schema_validation_enabled configuration
#1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Set to `True` by default TODO, add test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new configuration option schema_validation_enabled to allow users to disable schema validation for needs. The flag is set to True by default, maintaining backward compatibility while providing an opt-out mechanism for schema validation.
Key Changes
- Added
schema_validation_enabledboolean configuration field with default valueTrue - Modified
process_schemas()to skip validation when the flag is disabled
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sphinx_needs/config.py | Adds the new schema_validation_enabled configuration field with appropriate metadata |
| sphinx_needs/schema/process.py | Implements early return in process_schemas() when validation is disabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
+ Coverage 86.87% 87.94% +1.06%
==========================================
Files 56 70 +14
Lines 6532 9626 +3094
==========================================
+ Hits 5675 8466 +2791
- Misses 857 1160 +303
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR adds a new configuration option
needs_schema_validation_enabledto allow users to disable schema validation for needs. The flag is set toTrueby default, maintaining backward compatibility while providing an opt-out mechanism for schema validation.