Skip to content

Conversation

@chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Nov 24, 2025

This PR adds a new configuration option needs_schema_validation_enabled to allow users to disable schema validation for needs. The flag is set to True by default, maintaining backward compatibility while providing an opt-out mechanism for schema validation.

Set to `True` by default

TODO, add test
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new configuration option schema_validation_enabled to allow users to disable schema validation for needs. The flag is set to True by default, maintaining backward compatibility while providing an opt-out mechanism for schema validation.

Key Changes

  • Added schema_validation_enabled boolean configuration field with default value True
  • Modified process_schemas() to skip validation when the flag is disabled

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sphinx_needs/config.py Adds the new schema_validation_enabled configuration field with appropriate metadata
sphinx_needs/schema/process.py Implements early return in process_schemas() when validation is disabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.94%. Comparing base (4e10030) to head (c34048c).
⚠️ Report is 194 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   86.87%   87.94%   +1.06%     
==========================================
  Files          56       70      +14     
  Lines        6532     9626    +3094     
==========================================
+ Hits         5675     8466    +2791     
- Misses        857     1160     +303     
Flag Coverage Δ
pytests 87.94% <100.00%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisjsewell chrisjsewell requested a review from Copilot November 24, 2025 14:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@chrisjsewell chrisjsewell merged commit 4759e27 into master Nov 24, 2025
21 checks passed
@chrisjsewell chrisjsewell deleted the disable-schema-validation branch November 24, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants