Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Improve logic for process_needextend #1037

Merged
merged 8 commits into from
Sep 26, 2023
Merged

🐛 Improve logic for process_needextend #1037

merged 8 commits into from
Sep 26, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Sep 25, 2023 •
edited
Loading

Do not add non-existing links, and warn if found

closes #976

@chrisjsewell chrisjsewell requested a review from danwos September 25, 2023 18:55
@chrisjsewell
Copy link
Member Author

@danwos I'd note that this did not, and still does not cover sub-IDs (a.k.a parts)

danwos
danwos approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
No support for need-parts is okay.
Not sure if there is really a use case for it, so let's wait for it before we support it :)

@chrisjsewell chrisjsewell merged commit 4e604d0 into master Sep 26, 2023
@chrisjsewell chrisjsewell deleted the 976/need-extend-bad-id branch September 26, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwos danwos danwos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

needextend: new link to not existing needs crashes
2 participants
@chrisjsewell @danwos