Fixed catalog annotation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
haiyangToAI
commented
Jan 12, 2021
•
haiyangToAI
commented
- issues caused by PDF 1.1 and PDF 1.2
- For Named Destination, a destination may be referred to indirectly by means of a name object (PDF 1.1) or a byte string (PDF 1.2)
- this PR will start supporting named destination extract for both PDF 1.1 and PDF 1.2
- issues caused by PDF 1.1 and PDF 1.2
ubmarco
requested changes
Jan 12, 2021
libpdf/catalog.py
Outdated
| if isinstance(pdf_catalog['Names'], PDFObjRef) and 'Dests' in pdf_catalog['Names'].resolve(): | ||
| name_tree = pdf_catalog['Names'].resolve()['Dests'].resolve() | ||
| elif isinstance(pdf_catalog['Names'], dict) and 'Dests' in pdf_catalog['Names']: | ||
| name_tree = pdf_catalog['Names']['Dests'].resolve() | ||
| # check if name tree not empty | ||
| if not name_tree: | ||
| LOG.info('Catalog extraction: name destination exists but is empty...') |
There was a problem hiding this comment.
Is this good or bad from a users' perspective?
Please remove the 3 dots. It either looks like the program processes something currently or something looks fishy in the PDF but the tool does not tell what.
| for index_name in range(0, len(item_dest['Names']), 2): | ||
| named_destination[name_obj_list[index_dest]['Names'][index_name].decode('utf-8')] = name_obj_list[ | ||
| index_dest | ||
| ]['Names'][index_name + 1] | ||
|
|
||
| for key_object in named_destination: |
There was a problem hiding this comment.
Did not load the code in my IDE, but it looks like named_destination is defined if name_tree is defined. Could it be named_destination is referenced before its definition?
There was a problem hiding this comment.
yes, you are right. It is referenced before definition. Done.
ubmarco
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.