Skip to content

Conversation

@adityamaru
Copy link
Contributor

@adityamaru adityamaru commented Nov 20, 2025

Add buildkitd version logging to action output

Summary

Added logging to display the buildkitd version after the daemon starts successfully. This provides visibility into which BuildKit version is being used during the "Starting Blacksmith builder" phase of the action.

The version is extracted from buildkitd --version output and logged using core.info(). If version detection fails for any reason, it falls back to debug logging without breaking the action.

Also includes a packageManager field addition to package.json (auto-generated by corepack) to lock the pnpm version to 8.15.9.

Review & Testing Checklist for Human

  • Run the action in a real workflow and verify that the buildkitd version appears in the logs under "Starting Blacksmith builder" (this is the most critical test - I cannot test this locally)
  • Verify the version output format is clear and useful (e.g., "buildkitd version: v0.12.5")
  • Confirm the action still works correctly even if version detection fails (should only log to debug, not fail the action)
  • Review whether the packageManager lock in package.json is desired (generally good practice for consistency)

Test Plan

  1. Trigger a workflow that uses this action
  2. Check the action logs under "Starting Blacksmith builder"
  3. Verify you see a line like: buildkitd version: X.Y.Z
  4. Optionally: Test with a custom buildkit-version input to ensure it logs the correct version

Notes


Note

Update CI workflows and refresh dist build artifacts (including source map).

  • CI/CD:
    • Update workflows in .github/workflows/ (build.yml, lint.yml, release.yml, test-action.yml, verify-build.yml).
  • Build Artifacts:
    • Refresh dist/index.js and add/update dist/index.js.map.

Written by Cursor Bugbot for commit 4a70932. This will update automatically on new commits. Configure here.

Log the buildkitd version after the daemon starts successfully
to provide visibility into which version is being used during
the 'Creating Blacksmith builder' phase of the action.

Co-Authored-By: maru@blacksmith.sh <adityamaru@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 2 commits November 20, 2025 03:08
Remove 'version: 8' from pnpm/action-setup in all workflows to allow
pnpm/action-setup to use the packageManager field from package.json.
This fixes the 'Multiple versions of pnpm specified' error in CI.

Co-Authored-By: maru@blacksmith.sh <adityamaru@gmail.com>
Restore pnpm version specification (8.15.9) in all GitHub Actions
workflows and remove the packageManager field from package.json.

This reverts the workflow changes from the previous commit while
keeping the buildkitd version logging feature.

Co-Authored-By: maru@blacksmith.sh <adityamaru@gmail.com>
@adityamaru adityamaru merged commit 53647ab into main Nov 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants