Skip to content

Conversation

@pbardea
Copy link
Contributor

@pbardea pbardea commented Oct 10, 2025

Summary

Log parent snapshot name and clone name from sticky disk response

This PR adds logging for the parent_snapshot_name and clone_name fields that are now returned from the getStickyDisk gRPC call (added in https://github.com/FastActions/fa/pull/2361).

Changes

  • Updated getStickyDisk return type to include parent_snapshot_name and clone_name
  • Extract these fields from the gRPC response
  • Log both values in setupStickyDisk when the disk is first obtained

This will help with debugging and understanding which snapshot and clone are being used for each build.

Example output

Sticky disk parent snapshot: snapshot-abc123
Sticky disk clone name: clone-xyz789

🤖 Generated with Claude Code


Note

Log parent_snapshot_name and clone_name from sticky disk response; extend getStickyDisk return type; update buf agent dependencies and add update-proto script.

  • Setup/Sticky Disk:
    • Extend getStickyDisk return to include parent_snapshot_name and clone_name and map them from the gRPC response in src/setup_builder.ts.
    • Log both values when obtaining the sticky disk in startAndConfigureBuildkitd.
  • Tooling/Deps:
    • Bump @buf/blacksmith_vm-agent.bufbuild_es to 1.9.0-20251006151057-c11382a97f51.2 and @buf/blacksmith_vm-agent.connectrpc_es to 1.6.1-20251006151057-c11382a97f51.2.
    • Add package.json script update-proto for updating these packages.
    • Update pnpm-lock.yaml accordingly.

Written by Cursor Bugbot for commit bedba08. This will update automatically on new commits. Configure here.

Log the parent_snapshot_name and clone_name fields returned from the
getStickyDisk gRPC call to help with debugging and understanding which
snapshot and clone are being used for each build.

Related to FastActions/fa#2361

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@pbardea pbardea requested a review from adityamaru October 10, 2025 19:30
@pbardea pbardea marked this pull request as draft October 10, 2025 19:35
pbardea and others added 3 commits October 10, 2025 15:43
Update vm-agent protobuf packages from 1.5.0 to 1.9.0 (latest compatible
version) and add npm script for easy updates in the future.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@pbardea
Copy link
Contributor Author

pbardea commented Oct 10, 2025

@pbardea pbardea marked this pull request as ready for review October 10, 2025 20:16
@pbardea pbardea merged commit 472f79c into main Oct 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants