checkout: add timeout and integrity checks to git mirror post step #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap mirror refresh, GC, and fsck with timeouts (2min/60s/30s respectively) using the `timeout` command, which properly terminates child processes. If any operation fails or times out, skip sticky disk commit. Report failures/timeouts as internal metrics to Blacksmith agent. Ordering: refresh → GC → fsck (as final integrity gate) → unmount → commit. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
adityamaru
changed the title
getAuthConfigArgs calls new URL(repoUrl) which throws on malformed URLs. Since refreshMirror's return type implies it won't throw, move this call inside the existing try/catch so errors are captured in the OperationResult. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
If commitStickyDisk throws, cleanup() exited before returning the result containing GC and fsck outcomes. This caused cleanupResult in main.ts to remain undefined, silently skipping metric reporting for GC/fsck failures. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
vmHydratedGitMirror was computed in main.ts before calling cleanup(), so GC/fsck/refresh failures inside cleanup() would set shouldCommit=false but leave vmHydratedGitMirror=true. This could cause the backend to mark hydration as complete even though no valid disk was persisted. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
timeoutcommand for proper process terminationTesting
Deploy to Blacksmith VM and verify:
reasontags (failure vs timeout)🤖 Generated with Claude Code
Note
Medium Risk
Changes the post-step cache persistence decision and adds new time-bounded git operations (refresh/GC/fsck), which could alter when sticky disks are committed and impact cache availability if misclassified as failures/timeouts.
Overview
Adds bounded execution and structured result reporting for Blacksmith git-mirror maintenance:
refreshMirror, mirrorgc --auto, and newfscknow run viatimeoutwith explicit success/timeout/failure results.Reworks the post-step cleanup flow to treat refresh/GC/fsck issues as a hard gate (sets
shouldCommit=falseand clearsvmHydratedGitMirror) before unmount/commit, and adds fire-and-forget internal metric reporting (git_mirror_refresh_failure,git_mirror_gc_failure,git_mirror_fsck_failure) tagged withreason(timeout vs failure).Written by Cursor Bugbot for commit 13e7335. This will update automatically on new commits. Configure here.