-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[env] pass salt argument to instantiate host function #599
Conversation
bd850f5
to
ad2a5cb
Compare
doc tests seem to be failing |
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
==========================================
- Coverage 82.66% 79.76% -2.91%
==========================================
Files 161 161
Lines 7414 7389 -25
==========================================
- Hits 6129 5894 -235
- Misses 1285 1495 +210
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #593. Rel paritytech/substrate#7482
Allows specifying
salt
when instantiating a contract from within a contract e.g. (fromdelegator
):todo
[u8; 4]
. Is it possible/desirable to make this generic with the constructor builder. If not shouldSalt
be added to theEnvironment
trait?