Skip to content

Simple CI + URL fixes #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

Simple CI + URL fixes #2700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
640aad2
Don't run `submit-contract-sizes-comment` for tags
cmichi Oct 31, 2025
632fdc3
Point links to `pallet-revive` instead of `pallet-contracts`
cmichi Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,12 +1000,14 @@ jobs:
});
console.log(`Issue created: ${issue.data.html_url}`);

submit-contract-sizes:
submit-contract-sizes-comment:
runs-on: ubuntu-latest
needs: [ci-image, process-contract-sizes, process-forced-abi-contract-sizes]
permissions:
pull-requests: write
if: github.ref != 'refs/heads/master'
# We don't submit the comment about contract size changes for CI runs on `master` or on tags.
# There is no PR associated to those.
if: github.ref != 'refs/heads/master' && !startsWith(github.ref, 'refs/tags/')
steps:
- name: Checkout
uses: actions/checkout@v5
Expand Down
2 changes: 1 addition & 1 deletion crates/env/src/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ pub fn ecdsa_to_eth_address(pubkey: &[u8; 33], output: &mut [u8; 20]) -> Result<
///
/// - If sr25519 signature cannot be verified.
///
/// **WARNING**: this function is from the [unstable interface](https://github.com/paritytech/substrate/tree/master/frame/contracts#unstable-interfaces),
/// **WARNING**: this function is from the [unstable interface](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/revive#unstable-interfaces)
/// which is unsafe and normally is not available on production chains.
#[cfg(feature = "unstable-hostfn")]
pub fn sr25519_verify(
Expand Down
2 changes: 1 addition & 1 deletion crates/env/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ pub trait EnvBackend {
///
/// - If the signature verification failed.
///
/// **WARNING**: this function is from the [unstable interface](https://github.com/paritytech/substrate/tree/master/frame/contracts#unstable-interfaces),
/// **WARNING**: this function is from the [unstable interface](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/revive#unstable-interfaces)
/// which is unsafe and normally is not available on production chains.
#[cfg(feature = "unstable-hostfn")]
fn sr25519_verify(
Expand Down
3 changes: 1 addition & 2 deletions crates/ink/src/env_access.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,8 +1030,7 @@ where
///
/// For more details visit: [`ink_env::sr25519_verify`]
///
/// todo
/// **WARNING**: this function is from the [unstable interface](https://github.com/paritytech/substrate/tree/master/frame/contracts#unstable-interfaces),
/// **WARNING**: this function is from the [unstable interface](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/revive#unstable-interfaces),
/// which is unsafe and normally is not available on production chains.
#[cfg(feature = "unstable-hostfn")]
pub fn sr25519_verify(
Expand Down
Loading