Refactor out transcode as a separate library #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbielejec
requested review from
Robbepop,
cmichi,
ascjones and
HCastano
as code owners
|
User @fbielejec, please sign the CLA here. |
|
|
This was referenced Jun 8, 2022
gilescope
reviewed
Jun 26, 2022
| /// Decode hex string with or without 0x prefix | ||
| pub fn decode_hex(input: &str) -> Result<Vec<u8>, hex::FromHexError> { | ||
| if input.starts_with("0x") { | ||
| hex::decode(input.trim_start_matches("0x")) |
There was a problem hiding this comment.
You don't need the if here. You can call this function regardless of if the string is prefixed with an 0x or not.
There was a problem hiding this comment.
Happy to approve a small PR which refactors this
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the bits responsible for encoding contract creator and message calls into a separate library.
It's intention is to facilitate building various tools for interacting with contracts.
One possible use case is creating automated end-to-end tests written in Rust, declarative DSL based tools for describing pipelines for deploying / updating non-trivial smart contract suites (think Truffle / Hardhat) etc.
For that reason the Licence is Apache (although I have cargo-culted the contract-metadata library in that respect, GPL with ClasspathException would likely also be permissive enough - Although I'm Not A Lawyer).