Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instantiate_with_code with already uploaded code #594

Merged
merged 1 commit into from
May 30, 2022
Merged

Fix instantiate_with_code with already uploaded code #594

merged 1 commit into from
May 30, 2022

Conversation

ascjones
Copy link
Collaborator

When calling instantiate_with_code more than once (with different salt values), since the code has already been uploaded on the first call, subsequent calls will not store the code and not raise the CodeStored event.

Fixes #589.

@ascjones ascjones merged commit d3fc06c into master May 30, 2022
@ascjones ascjones deleted the aj/fix-instantiate-with-code branch May 30, 2022 09:36
@forgetso
Copy link
Contributor

Thanks!

This was referenced Jul 12, 2022
Closed
Merged
@ascjones ascjones mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

@Robbepop Robbepop Awaiting requested review from Robbepop

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: Failed to find CodeStored event
3 participants
@ascjones @forgetso @HCastano