Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually convert Url::url to String in order to include the default port #591

Merged
merged 1 commit into from
May 27, 2022
Merged

Manually convert Url::url to String in order to include the default port #591

merged 1 commit into from
May 27, 2022

Conversation

h4nsu
Copy link
Contributor

@h4nsu h4nsu commented May 27, 2022

Fixes #587

@cla-bot-2021
Copy link

cla-bot-2021 bot commented May 27, 2022

User @h4nsu, please sign the CLA here.

ascjones
ascjones approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascjones ascjones merged commit 9902ee6 into use-ink:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@Robbepop Robbepop Awaiting requested review from Robbepop

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to connect via the default port
2 participants
@h4nsu @ascjones