Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure constructor selector is looking for the exact function name #562

Merged
merged 2 commits into from
May 18, 2022
Merged

Make sure constructor selector is looking for the exact function name #562

merged 2 commits into from
May 18, 2022

Conversation

forgetso
Copy link
Contributor

Fixes #561

ascjones
ascjones reviewed May 18, 2022
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not sure why I did contains. 🤷

Please run cargo fmt, CI check is failing

ascjones
ascjones approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@forgetso
Copy link
Contributor Author

No problem

@ascjones ascjones merged commit 5139757 into use-ink:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@Robbepop Robbepop Awaiting requested review from Robbepop

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid metadata: both a constructor and message found with name 'default'
2 participants
@forgetso @ascjones