Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rusty-cachier and remove old pre_cache.sh #556

Merged
merged 9 commits into from
May 16, 2022
Merged

Introduce rusty-cachier and remove old pre_cache.sh #556

merged 9 commits into from
May 16, 2022

Conversation

rcny
Copy link
Contributor

@rcny rcny commented May 11, 2022

This PR enables rusty-cachier for this project, which will allow future PRs to reuse CARGO_HOME and CARGO_TARGET_DIR caches from the latest master, improving run time for all Rust-related CI jobs.

@rcny rcny added the ci something to do with continious integration label May 11, 2022
@rcny rcny self-assigned this May 11, 2022
@rcny
Copy link
Contributor Author

rcny commented May 13, 2022

rusty-cachier fails gracefully now as it awaits cache population from master and its later distribution to the all related runner machines via the scheduler.
@TriplEight Let's proceed and merge it as is into master.

@rcny rcny marked this pull request as ready for review May 13, 2022 16:42
@rcny rcny requested review from a team, Robbepop, cmichi, ascjones and HCastano as code owners May 13, 2022 16:42
@rcny rcny requested a review from TriplEight May 13, 2022 16:43
TriplEight
TriplEight approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just be aware tat you're doing snapshots on every run, not just on master.

ascjones
ascjones reviewed May 16, 2022
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's rusty-cachier? An internal tool we have developed?

@rcny
Copy link
Contributor Author

rcny commented May 16, 2022 •
edited
Loading

Just be aware tat you're doing snapshots on every run, not just on master.

rusty-cachier snapshot create command creates union mounts, it doesn't download/upload any cache entitities.

What's rusty-cachier? An internal tool we have developed?

Yes, our new caching tool.

@rcny rcny merged commit 7b06930 into master May 16, 2022
@rcny rcny deleted the vi-rusty-cachier branch May 16, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones left review comments

@alvicsam alvicsam alvicsam approved these changes

@TriplEight TriplEight TriplEight approved these changes

@Robbepop Robbepop Awaiting requested review from Robbepop

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@HCastano HCastano Awaiting requested review from HCastano

Assignees

@rcny rcny

Labels
ci something to do with continious integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcny @ascjones @TriplEight @alvicsam