Include ink_linting folder in releases + Test publish/install in CI
#463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
requested review from
a team,
Robbepop,
ascjones and
HCastano
as code owners
cmichi
changed the title
ink_linting folder in releasesink_linting folder in releases + Test publish/install in CI
ascjones
approved these changes
Mar 15, 2022
| before_script: | ||
| # Set up a local registry. | ||
| - mkdir -p ./estuary/crates/ ./estuary/indices/ | ||
| - estuary --base-url=http://0.0.0.0:7878 --crate-dir ./estuary/crates/ --index-dir ./estuary/indices & |
There was a problem hiding this comment.
So is estuary already part of docker image or installed somewhere else?
There was a problem hiding this comment.
I added it this morning in paritytech/scripts#396 and ran the Docker build manually, so it's part of the image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm super unhappy about the
_Cargo.tomlsolution, but can't think of anything better right now.Note that we also use this hack for the crates in
templates/.