Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scripts used in CI to new location #426

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

sergejparity
Copy link
Contributor

In order to standardize management of scripts and helper files used in CI it is decided that such items should reside in common location ./scripts/ci for all repositories.
Related issue: https://github.com/paritytech/ci_cd/issues/313

@sergejparity sergejparity requested review from ascjones, cmichi, Robbepop, HCastano and a team February 9, 2022 10:47
@cmichi
Copy link
Collaborator

cmichi commented Feb 9, 2022

@sergejparity Why not a hidden folder with .scripts? Those CI maintenance scripts would be hidden from regular users then and it would be a clear separation of domains ‒ project stuff and unrelated CI/CD things.

@sergejparity
Copy link
Contributor Author

sergejparity commented Feb 9, 2022

@cmichi when we were evaluating where to store CI scripts. We took into an account current location. And most of projects stores them either in ./scripts or ./scripts/ci/ folders. So we decided to use ./scripts/ci to minimize efforts for unification.
Also some projects already actively use ./scripts/ folder for stuff other than CI.

@cmichi cmichi merged commit 38b3ac7 into master Feb 10, 2022
@cmichi cmichi deleted the sk-unify-ci-scripts-location branch February 10, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants