Fix failing test for Windows master CI
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
commented
Aug 4, 2021
| @@ -201,7 +201,7 @@ fn exec_cargo_for_wasm_target( | |||
| // Currently will override user defined RUSTFLAGS from .cargo/config. See https://github.com/paritytech/cargo-contract/issues/98. | |||
| std::env::set_var( | |||
| "RUSTFLAGS", | |||
| "-C link-arg=-z -C link-arg=stack-size=65536 -C link-arg=--import-memory", | |||
| "-C link-arg=-zstack-size=65536 -C link-arg=--import-memory", | |||
There was a problem hiding this comment.
For some reason (which I don't fully understand) there is an issue with the Windows CI currently failing on master for one specific test if the -z is passed separately of the stack-size argument, which actually belongs to it. Since both versions should be equal I would change it to this.
cmichi
commented
Aug 4, 2021
| ), | ||
| "Expected a different output, found {:?}", | ||
| res | ||
| ); |
There was a problem hiding this comment.
This test is flaky sometimes, if the CI is re-run it succeeds. I added output of the res to have some more info when if fails spuriously again.
cmichi
changed the title
cargo contract test on Windowsmaster CI
ascjones
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.