Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply clippy to all code #306

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Apply clippy to all code #306

merged 2 commits into from
Jul 20, 2021

Conversation

athei
Copy link
Contributor

@athei athei commented Jul 20, 2021

The clippy CI job wasn't applied to testing code. I fixed that and also corrected all clippy lints that came up due to this.

@athei athei added the ci something to do with continious integration label Jul 20, 2021
@athei athei requested review from ascjones and cmichi July 20, 2021 12:27
ascjones
ascjones approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

cmichi
cmichi approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh great, thanks!

@cmichi cmichi merged commit 5f3a7a7 into master Jul 20, 2021
@cmichi cmichi deleted the at-fix-clippy branch July 20, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
ci something to do with continious integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@athei @ascjones @cmichi